93b3c33976
## Context This commit adds the supporting infrastructure that makes the assign feature work end-to-end. ## Components Added/Modified ### SmartDag - Main view component for graph-based task management - Integrates TaskCardGrid and WorkflowGraph - Has 'Assign' mode toggle button - Passes archetypes and assignMode to WorkflowGraph - Manages filter state (hideClosed, sortReadyFirst, etc.) ### useGraphAnalysis Hook - Extracted graph analysis logic for reuse - Returns: actionableNodeIds, cycleNodeIdSet, blockerTooltipMap, etc. - Used by both SmartDag and AssignmentPanel - Ensures consistent 'actionable' definition across components ### UnifiedShell - Added assignMode state - Added selectedAssignIssue state - Renders AssignmentPanel when in graph view + assign mode - Wires up onAssignModeChange and onSelectedIssueChange callbacks ## Design Philosophy - Shared hook means single source of truth for 'actionable' - Clean separation between view (SmartDag) and sidebar (AssignmentPanel) - URL state preserved for navigation ## Test Coverage - SmartDag tests: 12 tests covering buttons, callbacks, imports - useGraphAnalysis tests: 6 tests covering cycle detection, blockers - UnifiedShell tests: 9 tests covering state and rendering
60 lines
3.4 KiB
TypeScript
60 lines
3.4 KiB
TypeScript
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import fs from 'fs/promises';
|
|
import path from 'path';
|
|
|
|
// Test that the UnifiedShell component exists and exports correctly
|
|
test('UnifiedShell - file exists and exports', async () => {
|
|
const fileContent = await fs.readFile(path.join(process.cwd(), 'src/components/shared/unified-shell.tsx'), 'utf-8');
|
|
assert.ok(fileContent.includes('export function UnifiedShell'), 'Should export UnifiedShell function');
|
|
assert.ok(fileContent.includes('export interface UnifiedShellProps'), 'Should export UnifiedShellProps interface');
|
|
});
|
|
|
|
// Test that UnifiedShell has assignMode state
|
|
test('UnifiedShell - has assignMode state', async () => {
|
|
const fileContent = await fs.readFile(path.join(process.cwd(), 'src/components/shared/unified-shell.tsx'), 'utf-8');
|
|
assert.ok(fileContent.includes('assignMode'), 'Should have assignMode state');
|
|
});
|
|
|
|
// Test that UnifiedShell has selectedAssignIssue state
|
|
test('UnifiedShell - has selectedAssignIssue state', async () => {
|
|
const fileContent = await fs.readFile(path.join(process.cwd(), 'src/components/shared/unified-shell.tsx'), 'utf-8');
|
|
assert.ok(fileContent.includes('selectedAssignIssue'), 'Should have selectedAssignIssue state');
|
|
});
|
|
|
|
// Test that SmartDag receives onAssignModeChange callback
|
|
test('UnifiedShell - passes onAssignModeChange to SmartDag', async () => {
|
|
const fileContent = await fs.readFile(path.join(process.cwd(), 'src/components/shared/unified-shell.tsx'), 'utf-8');
|
|
assert.ok(fileContent.includes('onAssignModeChange'), 'Should pass onAssignModeChange to SmartDag');
|
|
});
|
|
|
|
// Test that SmartDag receives onSelectedIssueChange callback
|
|
test('UnifiedShell - passes onSelectedIssueChange to SmartDag', async () => {
|
|
const fileContent = await fs.readFile(path.join(process.cwd(), 'src/components/shared/unified-shell.tsx'), 'utf-8');
|
|
assert.ok(fileContent.includes('onSelectedIssueChange'), 'Should pass onSelectedIssueChange to SmartDag');
|
|
});
|
|
|
|
// Test that AssignmentPanel is imported
|
|
test('UnifiedShell - imports AssignmentPanel', async () => {
|
|
const fileContent = await fs.readFile(path.join(process.cwd(), 'src/components/shared/unified-shell.tsx'), 'utf-8');
|
|
assert.ok(fileContent.includes('AssignmentPanel'), 'Should import AssignmentPanel');
|
|
});
|
|
|
|
// Test that AssignmentPanel is rendered conditionally based on view and assignMode
|
|
test('UnifiedShell - renders AssignmentPanel conditionally', async () => {
|
|
const fileContent = await fs.readFile(path.join(process.cwd(), 'src/components/shared/unified-shell.tsx'), 'utf-8');
|
|
// Check for the condition: view === 'graph' && assignMode
|
|
assert.ok(fileContent.includes("view === 'graph' && assignMode"), 'Should check view === graph && assignMode condition for AssignmentPanel');
|
|
});
|
|
|
|
// Test that SwarmWorkspace import is removed (deprecated)
|
|
test('UnifiedShell - does not import SwarmWorkspace', async () => {
|
|
const fileContent = await fs.readFile(path.join(process.cwd(), 'src/components/shared/unified-shell.tsx'), 'utf-8');
|
|
assert.ok(!fileContent.includes('SwarmWorkspace'), 'Should NOT import SwarmWorkspace (deprecated)');
|
|
});
|
|
|
|
// Test that SwarmMissionPicker import is removed (deprecated)
|
|
test('UnifiedShell - does not import SwarmMissionPicker', async () => {
|
|
const fileContent = await fs.readFile(path.join(process.cwd(), 'src/components/shared/unified-shell.tsx'), 'utf-8');
|
|
assert.ok(!fileContent.includes('SwarmMissionPicker'), 'Should NOT import SwarmMissionPicker (deprecated)');
|
|
});
|