parsers/schwab: emit paired BUY for recent SELL (vest synthesis)
Schwab Stock Plan Services doesn't email vest-release confirmations to the employee inbox — only the same-day-sell trade-executed alert lands. The vest itself was invisible to broker-sync, so the META cadence panel in the wealth dashboard has been missing the May 2026 vest BUY and would keep missing every future vest. Synthesis: when a SELL email's trade date is on/after the configured boundary (default 2026-04-01), also emit a paired BUY with identical date/qty/price/symbol. Notes link the pair via the SELL's external_id. Verified true across 14 historical vests — 100% same-day-sell pattern, SELL qty == vest qty. Boundary stops the synthesis from back-filling vests prior to 2026-04 which already have csv-sourced BUY rows in Wealthfolio from the historical one-shot backfill (last vest 2026-02-18). The csv BUYs and inferred BUYs have distinct external_ids, so re-running against old emails would double-count without this guard. Override via env var `SCHWAB_VEST_INFER_FROM_DATE=yyyy-mm-dd` on the broker-sync-imap cron. Tests: 4 new cases — recent SELL pairs, old SELL doesn't pair, env override works, BUY-direction emails (rare) don't get paired. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
parent
abf9fa7cb5
commit
17c2a69c6c
2 changed files with 134 additions and 21 deletions
|
|
@ -80,5 +80,66 @@ def test_external_id_is_stable_across_reruns() -> None:
|
|||
|
||||
def test_price_with_commas_parses() -> None:
|
||||
html = _SELL.replace("$612.34", "$1,612.34")
|
||||
a = parse_schwab_email(html)[0]
|
||||
assert a.unit_price == Decimal("1612.34")
|
||||
# The first activity is the inferred BUY (date 2025-01-23 ≥ 2026-04-01? no →
|
||||
# only one activity for this old-dated email), so index 0 is the SELL.
|
||||
acts = parse_schwab_email(html)
|
||||
sell = next(a for a in acts if a.activity_type is ActivityType.SELL)
|
||||
assert sell.unit_price == Decimal("1612.34")
|
||||
|
||||
|
||||
# --- Inferred vest BUY ---------------------------------------------------
|
||||
|
||||
|
||||
def _recent_sell(date_iso: str = "2026-05-19", qty: str = "55", price: str = "609.35") -> str:
|
||||
return f"""
|
||||
<html><body><table>
|
||||
<tr><td class="dark-background-body" align="right">{date_iso}</td></tr>
|
||||
<tr><td class="dark-background-body" align="right">Sold</td></tr>
|
||||
<tr><td class="dark-background-body" align="right">{qty}</td></tr>
|
||||
<tr><td class="dark-background-body" align="right">META</td></tr>
|
||||
<tr><td class="dark-background-body" align="right">${price}</td></tr>
|
||||
</table></body></html>
|
||||
"""
|
||||
|
||||
|
||||
def test_recent_sell_emits_paired_buy() -> None:
|
||||
"""SELL dated on/after the synthesis boundary triggers a paired BUY."""
|
||||
acts = parse_schwab_email(_recent_sell())
|
||||
assert len(acts) == 2
|
||||
|
||||
buy = next(a for a in acts if a.activity_type is ActivityType.BUY)
|
||||
sell = next(a for a in acts if a.activity_type is ActivityType.SELL)
|
||||
|
||||
assert buy.quantity == sell.quantity == Decimal("55")
|
||||
assert buy.unit_price == sell.unit_price == Decimal("609.35")
|
||||
assert buy.date == sell.date
|
||||
assert buy.symbol == sell.symbol == "META"
|
||||
assert "schwab-vest-inferred-from-same-day-sell" in (buy.notes or "")
|
||||
assert buy.external_id == "schwab:vest:2026-05-19:META:BUY:55"
|
||||
assert sell.external_id == "schwab:2026-05-19:META:SELL:55"
|
||||
|
||||
|
||||
def test_old_sell_emits_only_sell() -> None:
|
||||
"""SELL dated before 2026-04-01 (default boundary) skips the paired BUY —
|
||||
those vests already have csv-sourced BUY rows in Wealthfolio."""
|
||||
acts = parse_schwab_email(_recent_sell(date_iso="2025-08-19"))
|
||||
assert len(acts) == 1
|
||||
assert acts[0].activity_type is ActivityType.SELL
|
||||
|
||||
|
||||
def test_boundary_env_var_overrides(monkeypatch: object) -> None:
|
||||
"""The synthesis boundary is configurable via env var."""
|
||||
import os
|
||||
os.environ["SCHWAB_VEST_INFER_FROM_DATE"] = "2025-01-01"
|
||||
try:
|
||||
acts = parse_schwab_email(_recent_sell(date_iso="2025-08-19"))
|
||||
assert len(acts) == 2 # now in scope
|
||||
finally:
|
||||
del os.environ["SCHWAB_VEST_INFER_FROM_DATE"]
|
||||
|
||||
|
||||
def test_buy_email_does_not_emit_inferred_buy() -> None:
|
||||
"""BUY-direction emails (rare for workplace account) don't get paired."""
|
||||
acts = parse_schwab_email(_BUY.replace("2024-11-15", "2026-05-15"))
|
||||
assert len(acts) == 1
|
||||
assert acts[0].activity_type is ActivityType.BUY
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue