From 0293b5c6344b4907509955a764d9a26f73dd0660 Mon Sep 17 00:00:00 2001
From: Viktor Barzin <vbarzin@gmail.com>
Date: Wed, 24 Jun 2026 08:57:36 +0000
Subject: [PATCH] android-emulator: fix idle-sleeper dying with SIGPIPE before
 it could sleep
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Caught live-testing the previous commit: every sleeper run exited 141
(SIGPIPE) in ~1s with no output, never reaching the scale-down. Cause:
`set -o pipefail` + `dumpsys power | awk '...; exit'` — awk closes the pipe
after the first match while `kubectl exec` is still streaming dumpsys, so
the exec gets SIGPIPE, pipefail makes the pipeline 141, and set -e kills the
script before any echo. (My earlier dry-run missed it because it didn't run
under `set -euo pipefail`.)

Fix: drop pipefail; capture each exec to a var (`|| true`) then parse with
awk reading to END (no early `exit`), so nothing can SIGPIPE mid-stream and
a failed/booting exec falls through to the fail-safe "do not sleep" branch.
Also fetch the pod name via jsonpath instead of `-o name | head -1` (no pipe
to SIGPIPE, no `pod/` prefix to strip), and exec `adb` directly without the
`sh -c` wrapper.

Verified live: ran the corrected script as the gate ServiceAccount against
the stuck emulator (idle ~120h) — it logged "idle >= 6h ... scaling to zero"
and patched the deployment to replicas=0. The 6+ day pod is now asleep.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 stacks/android-emulator/gate.tf | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/stacks/android-emulator/gate.tf b/stacks/android-emulator/gate.tf
index 04b09f97..2300888c 100644
--- a/stacks/android-emulator/gate.tf
+++ b/stacks/android-emulator/gate.tf
@@ -189,23 +189,26 @@ resource "kubernetes_cron_job_v1" "idle_sleeper" {
               image   = "bitnami/kubectl:latest"
               command = ["/bin/bash", "-c"]
               args = [<<-EOT
-                set -euo pipefail
+                set -eu
                 NS=android-emulator
                 DEPLOY=android-emulator
                 IDLE_LIMIT_SECONDS=21600   # 6h with no user activity -> sleep
                 spec=$(kubectl -n $NS get deploy $DEPLOY -o jsonpath='{.spec.replicas}')
                 [ "$spec" = "0" ] && { echo "already asleep"; exit 0; }
-                pod=$(kubectl -n $NS get pods -l app=$DEPLOY --field-selector=status.phase=Running -o name | head -1)
+                pod=$(kubectl -n $NS get pods -l app=$DEPLOY --field-selector=status.phase=Running -o jsonpath='{.items[0].metadata.name}')
                 [ -z "$pod" ] && { echo "no running pod (booting?) — not sleeping"; exit 0; }
-                pod=$${pod#pod/}
-                # How long since the emulator was actually used? Compare the
-                # last user-activity time from dumpsys power (taps/keys/app
-                # launches, incl. noVNC clicks) against current guest uptime,
-                # both in ms on the guest uptime clock. Fail-safe: if adb is
-                # not answering yet (cold boot) these come back empty and we
-                # must NOT sleep.
-                uptime_ms=$(kubectl -n $NS exec $pod -- sh -c 'adb shell cat /proc/uptime' 2>/dev/null | awk '{printf "%d", $1*1000}')
-                last_ms=$(kubectl -n $NS exec $pod -- sh -c 'adb shell dumpsys power' 2>/dev/null | awk -F= '/mLastUserActivityTime\(excludingAttention\)/{gsub(/[^0-9]/,"",$2); print $2; exit}')
+                # How long since the emulator was actually used? Compare the last
+                # user-activity time from dumpsys power (taps/keys/app-launches,
+                # incl. noVNC clicks) with current guest uptime, both in ms on
+                # the guest uptime clock. Capture first, then parse: NO pipefail
+                # and no early `exit` in awk, so a streaming `dumpsys` can't
+                # SIGPIPE the exec and trip set -e (that bug made every run die
+                # 141 with no output). Fail-safe: a still-booting emulator (adb
+                # not ready) yields empty values -> do NOT sleep.
+                uptime_raw=$(kubectl -n $NS exec $pod -- adb shell cat /proc/uptime 2>/dev/null || true)
+                dump=$(kubectl -n $NS exec $pod -- adb shell dumpsys power 2>/dev/null || true)
+                uptime_ms=$(printf '%s' "$uptime_raw" | awk '{printf "%d", $1*1000}')
+                last_ms=$(printf '%s' "$dump" | awk -F= '/mLastUserActivityTime\(excludingAttention\)/{v=$2} END{gsub(/[^0-9]/,"",v); print v}')
                 if [ -z "$uptime_ms" ] || [ -z "$last_ms" ]; then
                   echo "could not read activity (emulator booting / adb not ready) — not sleeping"
                   exit 0