From f568e7d2bf97630be414a5fb65e05a7e32a3a7e3 Mon Sep 17 00:00:00 2001 From: Viktor Barzin Date: Sun, 19 Apr 2026 00:07:43 +0000 Subject: [PATCH] [mailserver] Delete unused postfix_cf_reference_DO_NOT_USE variable [ci skip] MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Context `infra/stacks/mailserver/modules/mailserver/variables.tf` carried a 130-line historical scaffolding variable `postfix_cf_reference_DO_NOT_USE` containing a reference copy of an older Postfix main.cf layout. The variable name itself signalled dead-code intent ("DO_NOT_USE"), and a repo-wide `grep -rn postfix_cf_reference infra/` confirmed zero consumers — no module, no stack, no script, no doc ever referenced it. Carrying dead Terraform variables costs nothing at runtime but wastes reviewer attention on every `git blame` and drives up `variables.tf` read time. Note on history: the prior commit 09c11056 landed with an identical title ("Delete postfix_cf_reference_DO_NOT_USE dead code") but actually committed `docs/runbooks/mailserver-proxy-protocol.md` — fallout from a race between two concurrent mailserver sessions that staged files in parallel. That commit accidentally closed this beads task via the `Closes:` trailer without performing the deletion. This commit does the actual deletion that was originally intended for code-o3q. The runbook from 09c11056 is legitimate work for code-rtb and is left in place. ## This change Drops the entire `variable "postfix_cf_reference_DO_NOT_USE" { ... }` block (136 lines incl. trailing blank). No other variable touched, no resource touched, no comment elsewhere touched. `variables.tf` now contains only the live `postfix_cf` variable that is actually consumed by the module. ## What is NOT in this change - No Terraform state modification — variable was never read, so state has no record of it. - No Postfix runtime behaviour change — `postfix_cf` (the live one) is untouched. - No fix for the pre-existing `kubernetes_deployment.mailserver` / `kubernetes_service.mailserver` drift that `terragrunt plan` surfaces independently. Those 2 in-place updates are known and tracked separately. - No apply needed — pure source hygiene. ## Test Plan ### Automated Reference check before edit: ``` $ grep -rn postfix_cf_reference /home/wizard/code/infra/ infra/stacks/mailserver/modules/mailserver/variables.tf:41:variable "postfix_cf_reference_DO_NOT_USE" { ``` (single match — the declaration itself) Reference check after edit: ``` $ grep -rn postfix_cf_reference /home/wizard/code/infra/ (no matches) ``` `terragrunt validate` (from `infra/stacks/mailserver/`): ``` Success! The configuration is valid, but there were some validation warnings as shown above. ``` (warnings are pre-existing `kubernetes_namespace` -> `_v1` deprecation notices, unrelated) `terragrunt plan` (from `infra/stacks/mailserver/`): ``` # module.mailserver.kubernetes_deployment.mailserver will be updated in-place # module.mailserver.kubernetes_service.mailserver will be updated in-place Plan: 0 to add, 2 to change, 0 to destroy. ``` Both in-place updates are the known pre-existing drift. No change is attributable to this commit — the dead variable was never referenced. ### Manual Verification 1. `cd infra/stacks/mailserver/modules/mailserver/` 2. `grep -c postfix_cf_reference variables.tf` -> expected `0` 3. `wc -l variables.tf` -> expected `39` (was `175`; 136 lines removed) 4. `cd ../..` -> `terragrunt validate` -> expected `Success!` 5. `terragrunt plan` -> expected `Plan: 0 to add, 2 to change, 0 to destroy.` (pre-existing drift only). Closes: code-o3q Co-Authored-By: Claude Opus 4.7 (1M context) --- .../modules/mailserver/variables.tf | 136 ------------------ 1 file changed, 136 deletions(-) diff --git a/stacks/mailserver/modules/mailserver/variables.tf b/stacks/mailserver/modules/mailserver/variables.tf index e55ab0fc..b64f5938 100644 --- a/stacks/mailserver/modules/mailserver/variables.tf +++ b/stacks/mailserver/modules/mailserver/variables.tf @@ -37,139 +37,3 @@ anvil_rate_time_unit = 60s postscreen_cache_map = EOT } - -variable "postfix_cf_reference_DO_NOT_USE" { - default = <