infra/stacks/novelapp/main.tf
Viktor Barzin 8b43692af0 [infra] Suppress Goldilocks vpa-update-mode label drift on all namespaces [ci skip]
## Context

Wave 3B-continued: the Goldilocks VPA dashboard (stacks/vpa) runs a Kyverno
ClusterPolicy `goldilocks-vpa-auto-mode` that mutates every namespace with
`metadata.labels["goldilocks.fairwinds.com/vpa-update-mode"] = "off"`. This
is intentional — Terraform owns container resource limits, and Goldilocks
should only provide recommendations, never auto-update. The label is how
Goldilocks decides per-namespace whether to run its VPA in `off` mode.

Effect on Terraform: every `kubernetes_namespace` resource shows the label
as pending-removal (`-> null`) on every `scripts/tg plan`. Dawarich survey
2026-04-18 confirmed the drift. Cluster-side count: 88 namespaces carry the
label (`kubectl get ns -o json | jq ... | wc -l`). Every TF-managed namespace
is affected.

This commit brings the intentional admission drift under the same
`# KYVERNO_LIFECYCLE_V1` discoverability marker introduced in c9d221d5 for
the ndots dns_config pattern. The marker now stands generically for any
Kyverno admission-webhook drift suppression; the inline comment records
which specific policy stamps which specific field so future grep audits
show why each suppression exists.

## This change

107 `.tf` files touched — every stack's `resource "kubernetes_namespace"`
resource gets:

```hcl
lifecycle {
  # KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode ClusterPolicy stamps this label on every namespace
  ignore_changes = [metadata[0].labels["goldilocks.fairwinds.com/vpa-update-mode"]]
}
```

Injection was done with a brace-depth-tracking Python pass (`/tmp/add_goldilocks_ignore.py`):
match `^resource "kubernetes_namespace" ` → track `{` / `}` until the
outermost closing brace → insert the lifecycle block before the closing
brace. The script is idempotent (skips any file that already mentions
`goldilocks.fairwinds.com/vpa-update-mode`) so re-running is safe.

Vault stack picked up 2 namespaces in the same file (k8s-users produces
one, plus a second explicit ns) — confirmed via file diff (+8 lines).

## What is NOT in this change

- `stacks/trading-bot/main.tf` — entire file is `/* … */` commented out
  (paused 2026-04-06 per user decision). Reverted after the script ran.
- `stacks/_template/main.tf.example` — per-stack skeleton, intentionally
  minimal. User keeps it that way. Not touched by the script (file
  has no real `resource "kubernetes_namespace"` — only a placeholder
  comment).
- `.terraform/` copies (e.g. `stacks/metallb/.terraform/modules/...`) —
  gitignored, won't commit; the live path was edited.
- `terraform fmt` cleanup of adjacent pre-existing alignment issues in
  authentik, freedify, hermes-agent, nvidia, vault, meshcentral. Reverted
  to keep the commit scoped to the Goldilocks sweep. Those files will
  need a separate fmt-only commit or will be cleaned up on next real
  apply to that stack.

## Verification

Dawarich (one of the hundred-plus touched stacks) showed the pattern
before and after:

```
$ cd stacks/dawarich && ../../scripts/tg plan

Before:
  Plan: 0 to add, 2 to change, 0 to destroy.
   # kubernetes_namespace.dawarich will be updated in-place
     (goldilocks.fairwinds.com/vpa-update-mode -> null)
   # module.tls_secret.kubernetes_secret.tls_secret will be updated in-place
     (Kyverno generate.* labels — fixed in 8d94688d)

After:
  No changes. Your infrastructure matches the configuration.
```

Injection count check:
```
$ rg -c 'KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode' stacks/ | awk -F: '{s+=$2} END {print s}'
108
```

## Reproduce locally
1. `git pull`
2. Pick any stack: `cd stacks/<name> && ../../scripts/tg plan`
3. Expect: no drift on the namespace's goldilocks.fairwinds.com/vpa-update-mode label.

Closes: code-dwx

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-18 21:15:27 +00:00

256 lines
6.2 KiB
HCL

variable "tls_secret_name" {
type = string
sensitive = true
}
resource "kubernetes_manifest" "external_secret" {
manifest = {
apiVersion = "external-secrets.io/v1beta1"
kind = "ExternalSecret"
metadata = {
name = "novelapp-secrets"
namespace = "novelapp"
}
spec = {
refreshInterval = "15m"
secretStoreRef = {
name = "vault-kv"
kind = "ClusterSecretStore"
}
target = {
name = "novelapp-secrets"
}
dataFrom = [{
extract = {
key = "novelapp"
}
}]
}
}
depends_on = [kubernetes_namespace.novelapp]
}
resource "kubernetes_namespace" "novelapp" {
metadata {
name = "novelapp"
labels = {
"istio-injection" : "disabled"
tier = local.tiers.aux
}
}
lifecycle {
# KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode ClusterPolicy stamps this label on every namespace
ignore_changes = [metadata[0].labels["goldilocks.fairwinds.com/vpa-update-mode"]]
}
}
module "tls_secret" {
source = "../../modules/kubernetes/setup_tls_secret"
namespace = kubernetes_namespace.novelapp.metadata[0].name
tls_secret_name = var.tls_secret_name
}
resource "kubernetes_persistent_volume_claim" "novelapp-data" {
metadata {
name = "novelapp-data-proxmox"
namespace = kubernetes_namespace.novelapp.metadata[0].name
annotations = {
"resize.topolvm.io/threshold" = "80%"
"resize.topolvm.io/increase" = "100%"
"resize.topolvm.io/storage_limit" = "5Gi"
}
}
spec {
access_modes = ["ReadWriteOnce"]
storage_class_name = "proxmox-lvm"
resources {
requests = {
storage = "1Gi"
}
}
}
}
resource "kubernetes_deployment" "novelapp" {
metadata {
name = "novelapp"
namespace = kubernetes_namespace.novelapp.metadata[0].name
labels = {
app = "novelapp"
tier = local.tiers.aux
}
annotations = {
"reloader.stakater.com/auto" = "true"
}
}
lifecycle {
# DRIFT_WORKAROUND: CI pipeline owns image tag (kubectl set image from Woodpecker/GHA). Reviewed 2026-04-18.
ignore_changes = [
spec[0].template[0].spec[0].container[0].image,
]
}
spec {
replicas = 1
strategy {
type = "Recreate"
}
selector {
match_labels = {
app = "novelapp"
}
}
template {
metadata {
labels = {
app = "novelapp"
}
}
spec {
volume {
name = "data"
persistent_volume_claim {
claim_name = kubernetes_persistent_volume_claim.novelapp-data.metadata[0].name
}
}
container {
image = "mghee/novelapp:latest"
name = "novelapp"
image_pull_policy = "Always"
env {
name = "NODE_ENV"
value = "production"
}
env {
name = "DB_PATH"
value = "/app/data/novelapp.db"
}
env {
name = "DISABLE_BROWSER_SCRAPING"
value = "true"
}
env {
name = "PORT"
value = "3000"
}
env {
name = "AUTH_URL"
value = "https://novelapp.viktorbarzin.me"
}
env {
name = "AUTH_SECRET"
value_from {
secret_key_ref {
name = "novelapp-secrets"
key = "auth_secret"
}
}
}
env {
name = "AUTH_TRUST_HOST"
value = "true"
}
env {
name = "GOOGLE_CLIENT_ID"
value_from {
secret_key_ref {
name = "novelapp-secrets"
key = "google_client_id"
}
}
}
env {
name = "GOOGLE_CLIENT_SECRET"
value_from {
secret_key_ref {
name = "novelapp-secrets"
key = "google_client_secret"
}
}
}
env {
name = "ALLOWED_ORIGIN"
value = "https://novelapp.viktorbarzin.me"
}
volume_mount {
name = "data"
mount_path = "/app/data"
}
port {
container_port = 3000
}
resources {
requests = {
memory = "640Mi"
cpu = "10m"
}
limits = {
memory = "640Mi"
}
}
}
}
}
}
}
resource "kubernetes_service" "novelapp" {
metadata {
name = "novelapp"
namespace = kubernetes_namespace.novelapp.metadata[0].name
labels = {
"app" = "novelapp"
}
}
spec {
selector = {
app = "novelapp"
}
port {
name = "http"
port = 80
target_port = 3000
}
}
}
module "ingress" {
source = "../../modules/kubernetes/ingress_factory"
dns_type = "non-proxied"
namespace = kubernetes_namespace.novelapp.metadata[0].name
name = "novelapp"
tls_secret_name = var.tls_secret_name
extra_annotations = {
"gethomepage.dev/enabled" = "true"
"gethomepage.dev/name" = "NovelApp"
"gethomepage.dev/description" = "Web novel tracker"
"gethomepage.dev/icon" = "mdi-book-open-page-variant"
"gethomepage.dev/group" = "Other"
"gethomepage.dev/pod-selector" = ""
}
}
# RBAC — grant vabbit81 (Gheorghe) admin access to novelapp namespace
resource "kubernetes_role_binding" "novelapp_owner_vabbit81" {
metadata {
name = "novelapp-owner-vabbit81"
namespace = kubernetes_namespace.novelapp.metadata[0].name
}
role_ref {
api_group = "rbac.authorization.k8s.io"
kind = "ClusterRole"
name = "admin"
}
subject {
api_group = "rbac.authorization.k8s.io"
kind = "User"
name = "vabbit81@gmail.com"
}
}
# Sealed Secrets — encrypted secrets safe to commit to git
resource "kubernetes_manifest" "sealed_secrets" {
for_each = fileset(path.module, "sealed-*.yaml")
manifest = yamldecode(file("${path.module}/${each.value}"))
}