infra/stacks/url/main.tf
Viktor Barzin 8b43692af0 [infra] Suppress Goldilocks vpa-update-mode label drift on all namespaces [ci skip]
## Context

Wave 3B-continued: the Goldilocks VPA dashboard (stacks/vpa) runs a Kyverno
ClusterPolicy `goldilocks-vpa-auto-mode` that mutates every namespace with
`metadata.labels["goldilocks.fairwinds.com/vpa-update-mode"] = "off"`. This
is intentional — Terraform owns container resource limits, and Goldilocks
should only provide recommendations, never auto-update. The label is how
Goldilocks decides per-namespace whether to run its VPA in `off` mode.

Effect on Terraform: every `kubernetes_namespace` resource shows the label
as pending-removal (`-> null`) on every `scripts/tg plan`. Dawarich survey
2026-04-18 confirmed the drift. Cluster-side count: 88 namespaces carry the
label (`kubectl get ns -o json | jq ... | wc -l`). Every TF-managed namespace
is affected.

This commit brings the intentional admission drift under the same
`# KYVERNO_LIFECYCLE_V1` discoverability marker introduced in c9d221d5 for
the ndots dns_config pattern. The marker now stands generically for any
Kyverno admission-webhook drift suppression; the inline comment records
which specific policy stamps which specific field so future grep audits
show why each suppression exists.

## This change

107 `.tf` files touched — every stack's `resource "kubernetes_namespace"`
resource gets:

```hcl
lifecycle {
  # KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode ClusterPolicy stamps this label on every namespace
  ignore_changes = [metadata[0].labels["goldilocks.fairwinds.com/vpa-update-mode"]]
}
```

Injection was done with a brace-depth-tracking Python pass (`/tmp/add_goldilocks_ignore.py`):
match `^resource "kubernetes_namespace" ` → track `{` / `}` until the
outermost closing brace → insert the lifecycle block before the closing
brace. The script is idempotent (skips any file that already mentions
`goldilocks.fairwinds.com/vpa-update-mode`) so re-running is safe.

Vault stack picked up 2 namespaces in the same file (k8s-users produces
one, plus a second explicit ns) — confirmed via file diff (+8 lines).

## What is NOT in this change

- `stacks/trading-bot/main.tf` — entire file is `/* … */` commented out
  (paused 2026-04-06 per user decision). Reverted after the script ran.
- `stacks/_template/main.tf.example` — per-stack skeleton, intentionally
  minimal. User keeps it that way. Not touched by the script (file
  has no real `resource "kubernetes_namespace"` — only a placeholder
  comment).
- `.terraform/` copies (e.g. `stacks/metallb/.terraform/modules/...`) —
  gitignored, won't commit; the live path was edited.
- `terraform fmt` cleanup of adjacent pre-existing alignment issues in
  authentik, freedify, hermes-agent, nvidia, vault, meshcentral. Reverted
  to keep the commit scoped to the Goldilocks sweep. Those files will
  need a separate fmt-only commit or will be cleaned up on next real
  apply to that stack.

## Verification

Dawarich (one of the hundred-plus touched stacks) showed the pattern
before and after:

```
$ cd stacks/dawarich && ../../scripts/tg plan

Before:
  Plan: 0 to add, 2 to change, 0 to destroy.
   # kubernetes_namespace.dawarich will be updated in-place
     (goldilocks.fairwinds.com/vpa-update-mode -> null)
   # module.tls_secret.kubernetes_secret.tls_secret will be updated in-place
     (Kyverno generate.* labels — fixed in 8d94688d)

After:
  No changes. Your infrastructure matches the configuration.
```

Injection count check:
```
$ rg -c 'KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode' stacks/ | awk -F: '{s+=$2} END {print s}'
108
```

## Reproduce locally
1. `git pull`
2. Pick any stack: `cd stacks/<name> && ../../scripts/tg plan`
3. Expect: no drift on the namespace's goldilocks.fairwinds.com/vpa-update-mode label.

Closes: code-dwx

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-18 21:15:27 +00:00

442 lines
10 KiB
HCL

variable "tls_secret_name" {
type = string
sensitive = true
}
variable "mysql_host" { type = string }
data "vault_kv_secret_v2" "secrets" {
mount = "secret"
name = "url"
}
## Setup
## Need to manually add
## user: shlink
## password: var.url_shortener_mysql_password
## to the mysql tier
variable "domain" {
default = "url.viktorbarzin.me"
}
resource "kubernetes_namespace" "shlink" {
metadata {
name = "url"
labels = {
"istio-injection" : "disabled"
tier = local.tiers.aux
}
}
lifecycle {
# KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode ClusterPolicy stamps this label on every namespace
ignore_changes = [metadata[0].labels["goldilocks.fairwinds.com/vpa-update-mode"]]
}
}
resource "kubernetes_manifest" "external_secret" {
manifest = {
apiVersion = "external-secrets.io/v1beta1"
kind = "ExternalSecret"
metadata = {
name = "url-secrets"
namespace = "url"
}
spec = {
refreshInterval = "15m"
secretStoreRef = {
name = "vault-kv"
kind = "ClusterSecretStore"
}
target = {
name = "url-secrets"
}
dataFrom = [{
extract = {
key = "url"
}
}]
}
}
depends_on = [kubernetes_namespace.shlink]
}
# DB credentials from Vault database engine (rotated every 24h)
# NOTE: The kubernetes_secret "mysql_config" still uses plan-time db_password
# from KV. This ExternalSecret provides runtime-refreshed credentials. Once
# the deployment is migrated to use env_from with this secret, the plan-time
# kubernetes_secret can be removed.
resource "kubernetes_manifest" "db_external_secret" {
manifest = {
apiVersion = "external-secrets.io/v1beta1"
kind = "ExternalSecret"
metadata = {
name = "url-db-creds"
namespace = "url"
}
spec = {
refreshInterval = "15m"
secretStoreRef = {
name = "vault-database"
kind = "ClusterSecretStore"
}
target = {
name = "url-db-creds"
template = {
data = {
DB_USER = "shlink"
DB_PASSWORD = "{{ .password }}"
}
}
}
data = [{
secretKey = "password"
remoteRef = {
key = "static-creds/mysql-shlink"
property = "password"
}
}]
}
}
depends_on = [kubernetes_namespace.shlink]
}
module "tls_secret" {
source = "../../modules/kubernetes/setup_tls_secret"
namespace = kubernetes_namespace.shlink.metadata[0].name
tls_secret_name = var.tls_secret_name
}
resource "kubernetes_secret" "mysql_config" {
metadata {
name = "mysql-config"
namespace = kubernetes_namespace.shlink.metadata[0].name
annotations = {
"reloader.stakater.com/match" = "true"
}
}
data = {
"DB_USER" = "shlink"
"DB_PASSWORD" = data.vault_kv_secret_v2.secrets.data["db_password"]
}
}
# this depends on the mysql installation
# resource "kubectl_manifest" "mysql-user" {
# yaml_body = <<-YAML
# apiVersion: mysql.presslabs.org/v1alpha1
# kind: MysqlUser
# metadata:
# name: shlink
# namespace = kubernetes_namespace.shlink.metadata[0].name
# spec:
# user: shlink
# clusterRef:
# name: mysql-cluster
# namespace = kubernetes_namespace.shlink.metadata[0].name
# password:
# name: mysql-config
# key: password
# allowedHosts:
# - '%'
# YAML
# # permissions:
# # - schema: db-name-in-mysql
# # tables: ["table1", "table2"]
# # permissions:
# # - SELECT
# # - UPDATE
# # - CREATE
# # allowedHosts:
# # - localhost
# }
resource "kubernetes_deployment" "shlink" {
metadata {
name = "shlink"
namespace = kubernetes_namespace.shlink.metadata[0].name
labels = {
run = "shlink"
tier = local.tiers.aux
}
annotations = {
"reloader.stakater.com/auto" = "true"
}
}
spec {
replicas = 1
selector {
match_labels = {
run = "shlink"
}
}
template {
metadata {
labels = {
run = "shlink"
}
annotations = {
"diun.enable" = "true"
"diun.include_tags" = "^\\d+\\.\\d+\\.\\d+$"
"dependency.kyverno.io/wait-for" = "mysql.dbaas:3306"
}
}
spec {
container {
image = "shlinkio/shlink:5.0.2"
name = "shlink"
env {
name = "DEFAULT_DOMAIN"
value = var.domain
}
env {
name = "SHORT_DOMAIN_SCHEMA"
value = "https"
}
env {
name = "GEOLITE_LICENSE_KEY"
value_from {
secret_key_ref {
name = "url-secrets"
key = "geolite_license_key"
}
}
}
# DB config
env {
name = "DB_DRIVER"
value = "mysql"
}
env {
name = "DB_HOST"
value = var.mysql_host
}
# env {
# name = "DB_USER"
# value = "shlink"
# }
env_from {
secret_ref {
name = "url-db-creds"
}
}
# env {
# name = "DB_PASSWORD"
# value = data.vault_kv_secret_v2.secrets.data["db_password"]
# }
resources {
limits = {
memory = "960Mi"
}
requests = {
cpu = "25m"
memory = "960Mi"
}
}
port {
container_port = 8080
}
liveness_probe {
http_get {
path = "/rest/v3/health"
port = 8080
}
initial_delay_seconds = 15
period_seconds = 30
timeout_seconds = 5
failure_threshold = 5
}
readiness_probe {
http_get {
path = "/rest/v3/health"
port = 8080
}
initial_delay_seconds = 5
period_seconds = 30
timeout_seconds = 5
failure_threshold = 3
}
}
}
}
}
}
resource "kubernetes_service" "shlink" {
metadata {
name = "shlink"
namespace = kubernetes_namespace.shlink.metadata[0].name
labels = {
"run" = "shlink"
}
}
spec {
selector = {
run = "shlink"
}
port {
name = "http"
port = "80"
target_port = "8080"
}
}
}
module "ingress" {
source = "../../modules/kubernetes/ingress_factory"
dns_type = "proxied"
namespace = kubernetes_namespace.shlink.metadata[0].name
name = "url"
service_name = "shlink"
tls_secret_name = var.tls_secret_name
extra_annotations = {
"gethomepage.dev/enabled" = "true"
"gethomepage.dev/name" = "Shlink"
"gethomepage.dev/description" = "URL shortener"
"gethomepage.dev/icon" = "shlink.png"
"gethomepage.dev/group" = "Productivity"
"gethomepage.dev/pod-selector" = ""
"gethomepage.dev/widget.type" = "shlink"
"gethomepage.dev/widget.url" = "http://shlink.shlink.svc.cluster.local:8080"
"gethomepage.dev/widget.key" = data.vault_kv_secret_v2.secrets.data["api_key"]
}
}
# Shlink web client
resource "kubernetes_config_map" "shlink-web" {
metadata {
name = "shlink-web-servers"
namespace = kubernetes_namespace.shlink.metadata[0].name
annotations = {
"reloader.stakater.com/match" = "true"
}
}
data = {
"servers.json" = jsonencode([{
name = "Main"
url = "https://url.viktorbarzin.me"
apiKey = data.vault_kv_secret_v2.secrets.data["api_key"]
}])
}
}
resource "kubernetes_deployment" "shlink-web" {
metadata {
name = "shlink-web"
namespace = kubernetes_namespace.shlink.metadata[0].name
labels = {
run = "shlink-web"
tier = local.tiers.aux
}
annotations = {
"reloader.stakater.com/search" = "true"
}
}
spec {
replicas = 1
selector {
match_labels = {
run = "shlink-web"
}
}
template {
metadata {
labels = {
run = "shlink-web"
}
}
spec {
container {
image = "shlinkio/shlink-web-client"
name = "shlink-web"
volume_mount {
mount_path = "/usr/share/nginx/html/servers.json"
sub_path = "servers.json"
name = "config"
}
resources {
limits = {
memory = "64Mi"
}
requests = {
cpu = "10m"
memory = "64Mi"
}
}
port {
container_port = 8080
}
liveness_probe {
http_get {
path = "/"
port = 8080
}
initial_delay_seconds = 15
period_seconds = 30
timeout_seconds = 5
failure_threshold = 5
}
readiness_probe {
http_get {
path = "/"
port = 8080
}
initial_delay_seconds = 5
period_seconds = 30
timeout_seconds = 5
failure_threshold = 3
}
}
volume {
name = "config"
config_map {
name = "shlink-web-servers"
}
}
}
}
}
}
resource "kubernetes_service" "shlink-web" {
metadata {
name = "shlink-web"
namespace = kubernetes_namespace.shlink.metadata[0].name
labels = {
"run" = "shlink-web"
}
}
spec {
selector = {
run = "shlink-web"
}
port {
name = "http"
port = 80
target_port = 8080
}
}
}
module "ingress-web" {
source = "../../modules/kubernetes/ingress_factory"
dns_type = "proxied"
namespace = kubernetes_namespace.shlink.metadata[0].name
name = "shlink"
service_name = "shlink-web"
tls_secret_name = var.tls_secret_name
protected = true
extra_annotations = {
"gethomepage.dev/enabled" = "false"
"gethomepage.dev/name" = "Shlink Web"
"gethomepage.dev/description" = "URL shortener web client"
"gethomepage.dev/icon" = "shlink.png"
"gethomepage.dev/group" = "Productivity"
"gethomepage.dev/pod-selector" = ""
}
}