infra/stacks/ytdlp/main.tf
Viktor Barzin 8b43692af0 [infra] Suppress Goldilocks vpa-update-mode label drift on all namespaces [ci skip]
## Context

Wave 3B-continued: the Goldilocks VPA dashboard (stacks/vpa) runs a Kyverno
ClusterPolicy `goldilocks-vpa-auto-mode` that mutates every namespace with
`metadata.labels["goldilocks.fairwinds.com/vpa-update-mode"] = "off"`. This
is intentional — Terraform owns container resource limits, and Goldilocks
should only provide recommendations, never auto-update. The label is how
Goldilocks decides per-namespace whether to run its VPA in `off` mode.

Effect on Terraform: every `kubernetes_namespace` resource shows the label
as pending-removal (`-> null`) on every `scripts/tg plan`. Dawarich survey
2026-04-18 confirmed the drift. Cluster-side count: 88 namespaces carry the
label (`kubectl get ns -o json | jq ... | wc -l`). Every TF-managed namespace
is affected.

This commit brings the intentional admission drift under the same
`# KYVERNO_LIFECYCLE_V1` discoverability marker introduced in c9d221d5 for
the ndots dns_config pattern. The marker now stands generically for any
Kyverno admission-webhook drift suppression; the inline comment records
which specific policy stamps which specific field so future grep audits
show why each suppression exists.

## This change

107 `.tf` files touched — every stack's `resource "kubernetes_namespace"`
resource gets:

```hcl
lifecycle {
  # KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode ClusterPolicy stamps this label on every namespace
  ignore_changes = [metadata[0].labels["goldilocks.fairwinds.com/vpa-update-mode"]]
}
```

Injection was done with a brace-depth-tracking Python pass (`/tmp/add_goldilocks_ignore.py`):
match `^resource "kubernetes_namespace" ` → track `{` / `}` until the
outermost closing brace → insert the lifecycle block before the closing
brace. The script is idempotent (skips any file that already mentions
`goldilocks.fairwinds.com/vpa-update-mode`) so re-running is safe.

Vault stack picked up 2 namespaces in the same file (k8s-users produces
one, plus a second explicit ns) — confirmed via file diff (+8 lines).

## What is NOT in this change

- `stacks/trading-bot/main.tf` — entire file is `/* … */` commented out
  (paused 2026-04-06 per user decision). Reverted after the script ran.
- `stacks/_template/main.tf.example` — per-stack skeleton, intentionally
  minimal. User keeps it that way. Not touched by the script (file
  has no real `resource "kubernetes_namespace"` — only a placeholder
  comment).
- `.terraform/` copies (e.g. `stacks/metallb/.terraform/modules/...`) —
  gitignored, won't commit; the live path was edited.
- `terraform fmt` cleanup of adjacent pre-existing alignment issues in
  authentik, freedify, hermes-agent, nvidia, vault, meshcentral. Reverted
  to keep the commit scoped to the Goldilocks sweep. Those files will
  need a separate fmt-only commit or will be cleaned up on next real
  apply to that stack.

## Verification

Dawarich (one of the hundred-plus touched stacks) showed the pattern
before and after:

```
$ cd stacks/dawarich && ../../scripts/tg plan

Before:
  Plan: 0 to add, 2 to change, 0 to destroy.
   # kubernetes_namespace.dawarich will be updated in-place
     (goldilocks.fairwinds.com/vpa-update-mode -> null)
   # module.tls_secret.kubernetes_secret.tls_secret will be updated in-place
     (Kyverno generate.* labels — fixed in 8d94688d)

After:
  No changes. Your infrastructure matches the configuration.
```

Injection count check:
```
$ rg -c 'KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode' stacks/ | awk -F: '{s+=$2} END {print s}'
108
```

## Reproduce locally
1. `git pull`
2. Pick any stack: `cd stacks/<name> && ../../scripts/tg plan`
3. Expect: no drift on the namespace's goldilocks.fairwinds.com/vpa-update-mode label.

Closes: code-dwx

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-18 21:15:27 +00:00

359 lines
8.5 KiB
HCL

variable "tls_secret_name" {
type = string
sensitive = true
}
variable "slack_channel" { type = string }
variable "nfs_server" { type = string }
resource "kubernetes_manifest" "external_secret" {
manifest = {
apiVersion = "external-secrets.io/v1beta1"
kind = "ExternalSecret"
metadata = {
name = "ytdlp-secrets"
namespace = "ytdlp"
}
spec = {
refreshInterval = "15m"
secretStoreRef = {
name = "vault-kv"
kind = "ClusterSecretStore"
}
target = {
name = "ytdlp-secrets"
}
dataFrom = [{
extract = {
key = "ytdlp"
}
}]
}
}
depends_on = [kubernetes_namespace.ytdlp]
}
variable "redis_host" { type = string }
resource "kubernetes_namespace" "ytdlp" {
metadata {
name = "ytdlp"
labels = {
"istio-injection" : "disabled"
tier = local.tiers.aux
}
}
lifecycle {
# KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode ClusterPolicy stamps this label on every namespace
ignore_changes = [metadata[0].labels["goldilocks.fairwinds.com/vpa-update-mode"]]
}
}
module "tls_secret" {
source = "../../modules/kubernetes/setup_tls_secret"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
tls_secret_name = var.tls_secret_name
}
module "nfs_data_host" {
source = "../../modules/kubernetes/nfs_volume"
name = "ytdlp-data-host"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
nfs_server = "192.168.1.127"
nfs_path = "/srv/nfs/ytdlp"
}
module "nfs_highlights_data_host" {
source = "../../modules/kubernetes/nfs_volume"
name = "ytdlp-highlights-data-host"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
nfs_server = "192.168.1.127"
nfs_path = "/srv/nfs/ytdlp-highlights"
}
resource "kubernetes_deployment" "ytdlp" {
# resource "kubernetes_daemonset" "technitium" {
metadata {
name = "ytdlp"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
labels = {
app = "ytdlp"
tier = local.tiers.aux
}
annotations = {
"diun.enable" = "true"
}
}
spec {
# strategy {
# type = "Recreate"
# }
# replicas = 1
selector {
match_labels = {
app = "ytdlp"
}
}
template {
metadata {
labels = {
app = "ytdlp"
}
}
spec {
container {
image = "tzahi12345/youtubedl-material:nightly"
name = "ytdlp"
resources {
requests = {
cpu = "25m"
memory = "512Mi"
}
limits = {
memory = "512Mi"
}
}
port {
container_port = 17442
}
volume_mount {
mount_path = "/app/appdata"
name = "data"
}
volume_mount {
mount_path = "/app/audio"
name = "data"
}
volume_mount {
mount_path = "/app/video"
name = "data"
}
volume_mount {
mount_path = "/app/users"
name = "data"
}
volume_mount {
mount_path = "/app/subscriptions"
name = "data"
}
}
volume {
name = "data"
persistent_volume_claim {
claim_name = module.nfs_data_host.claim_name
}
}
# }
}
}
}
}
resource "kubernetes_service" "ytdlp" {
metadata {
name = "ytdlp"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
labels = {
"app" = "ytdlp"
}
}
spec {
selector = {
app = "ytdlp"
}
port {
name = "ytdlp"
port = 80
target_port = 17442
protocol = "TCP"
}
}
}
module "ingress" {
source = "../../modules/kubernetes/ingress_factory"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
name = "ytdlp"
tls_secret_name = var.tls_secret_name
host = "yt"
dns_type = "non-proxied"
extra_annotations = {
"gethomepage.dev/enabled" = "true"
"gethomepage.dev/name" = "yt-dlp"
"gethomepage.dev/description" = "Video downloader"
"gethomepage.dev/icon" = "youtube-dl.png"
"gethomepage.dev/group" = "Media & Entertainment"
"gethomepage.dev/pod-selector" = ""
}
}
# ----------------------
# yt-highlights service
# ----------------------
resource "kubernetes_deployment" "yt_highlights" {
metadata {
name = "yt-highlights"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
labels = {
app = "yt-highlights"
tier = local.tiers.aux
}
annotations = {
"diun.enable" = "true"
"reloader.stakater.com/auto" = "true"
}
}
spec {
replicas = 1
strategy {
type = "Recreate"
}
selector {
match_labels = {
app = "yt-highlights"
}
}
template {
metadata {
labels = {
app = "yt-highlights"
}
}
spec {
node_selector = {
"gpu" : "true"
}
toleration {
key = "nvidia.com/gpu"
value = "true"
effect = "NoSchedule"
}
container {
name = "yt-highlights"
image = "viktorbarzin/yt-highlights:v20-20260127"
image_pull_policy = "Always"
port {
container_port = 8000
}
env {
name = "ASR_MODEL"
value = "large-v3"
}
env {
name = "ASR_DEVICE"
value = "cuda"
}
env {
name = "OPENROUTER_MODEL"
value = "deepseek/deepseek-r1-0528:free"
}
env {
name = "OPENROUTER_API_KEY"
value_from {
secret_key_ref {
name = "ytdlp-secrets"
key = "openrouter_api_key"
}
}
}
env {
name = "DATA_PATH"
value = "/data"
}
env {
name = "SLACK_BOT_TOKEN"
value_from {
secret_key_ref {
name = "ytdlp-secrets"
key = "slack_bot_token"
}
}
}
env {
name = "SLACK_CHANNEL"
value = var.slack_channel
}
env {
name = "REDIS_URL"
value = "redis://${var.redis_host}:6379/0"
}
# Store model cache on NFS to avoid ephemeral storage eviction
env {
name = "HF_HOME"
value = "/data/cache/huggingface"
}
env {
name = "TORCH_HOME"
value = "/data/cache/torch"
}
volume_mount {
name = "data"
mount_path = "/data"
}
resources {
limits = {
"nvidia.com/gpu" = "1"
}
}
liveness_probe {
http_get {
path = "/health"
port = 8000
}
initial_delay_seconds = 180
period_seconds = 60
timeout_seconds = 60
failure_threshold = 10
}
}
volume {
name = "data"
persistent_volume_claim {
claim_name = module.nfs_highlights_data_host.claim_name
}
}
}
}
}
}
resource "kubernetes_service" "yt_highlights" {
metadata {
name = "yt-highlights"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
labels = {
"app" = "yt-highlights"
}
}
spec {
selector = {
app = "yt-highlights"
}
port {
name = "http"
port = 80
target_port = 8000
protocol = "TCP"
}
}
}
module "highlights_ingress" {
source = "../../modules/kubernetes/ingress_factory"
dns_type = "non-proxied"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
name = "yt-highlights"
tls_secret_name = var.tls_secret_name
host = "yt-highlights"
protected = true
extra_annotations = {
"gethomepage.dev/enabled" = "true"
"gethomepage.dev/name" = "YT Highlights"
"gethomepage.dev/description" = "AI video highlights"
"gethomepage.dev/icon" = "youtube.png"
"gethomepage.dev/group" = "Media & Entertainment"
"gethomepage.dev/pod-selector" = ""
}
}