Two coupled fixes for the hourly Slack noise + missing client IPs:
1. Move windows-kms off shared 10.0.20.200 to a dedicated MetalLB IP
10.0.20.202 with externalTrafficPolicy=Local, so vlmcsd sees real
WAN client IPs (pfSense WAN forwards do DNAT-only; ETP=Local skips
kube-proxy SNAT). Same pattern mailserver used pre-2026-04-19.
Sharing 10.0.20.200 is blocked because all 10 services there are
ETP=Cluster and MetalLB requires consistent ETP per shared IP.
2. Slack notifier now suppresses Slack posts for bare TCP open/close
pairs (no Application/Activation block) — these are Uptime Kuma's
port monitor and the new kubelet readiness/liveness probes. Probe
counts go to a new metric kms_connection_probes_total{source} where
source classifies the IP as internal_pod / cluster_node / external.
Real activations are unaffected.
Pod fluidity: added TCP readiness/liveness probes on 1688 to gate Pod
Ready on the listener actually being up — required for ETP=Local so
MetalLB only advertises 10.0.20.202 from a node where vlmcsd is serving.
pfSense side (applied separately, not codified):
- New alias k8s_kms_lb = 10.0.20.202 (KMS-only)
- WAN:1688 NAT + filter rule retargeted from k8s_shared_lb to k8s_kms_lb
- All other forwards on k8s_shared_lb (WireGuard, HTTPS, shadowsocks,
smtps, etc.) untouched
Runbook updated. Tests added for classify_source / is_probe / process_line.
110 lines
4.1 KiB
Python
110 lines
4.1 KiB
Python
"""Unit tests for slack_notifier classification + state machine.
|
|
|
|
Run with: cd infra/stacks/kms/files && python3 -m unittest test_slack_notifier
|
|
"""
|
|
import importlib.util
|
|
import os
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
# Load the notifier module from the dashed filename without executing main().
|
|
os.environ.setdefault("SLACK_WEBHOOK_URL", "http://example.invalid/webhook")
|
|
_spec = importlib.util.spec_from_file_location(
|
|
"slack_notifier", Path(__file__).parent / "slack-notifier.py"
|
|
)
|
|
nm = importlib.util.module_from_spec(_spec)
|
|
_spec.loader.exec_module(nm)
|
|
|
|
|
|
class ClassifySourceTests(unittest.TestCase):
|
|
def test_pod_cidr_is_internal_pod(self):
|
|
self.assertEqual(nm.classify_source("10.10.107.224"), "internal_pod")
|
|
self.assertEqual(nm.classify_source("10.10.0.1"), "internal_pod")
|
|
|
|
def test_cluster_lan_is_cluster_node(self):
|
|
self.assertEqual(nm.classify_source("10.0.20.103"), "cluster_node")
|
|
self.assertEqual(nm.classify_source("10.0.20.200"), "cluster_node")
|
|
|
|
def test_unknown_source_is_external(self):
|
|
self.assertEqual(nm.classify_source("8.8.8.8"), "external")
|
|
self.assertEqual(nm.classify_source("203.0.113.42"), "external")
|
|
|
|
def test_ipv6_external_default(self):
|
|
self.assertEqual(nm.classify_source("[2001:db8::1]"), "external")
|
|
|
|
|
|
class IsProbeTests(unittest.TestCase):
|
|
def test_open_close_only_is_probe(self):
|
|
self.assertTrue(nm.is_probe({"ip": "10.10.107.224"}))
|
|
|
|
def test_application_id_only_is_not_probe(self):
|
|
self.assertFalse(nm.is_probe({"ip": "10.0.20.103", "app": "Windows"}))
|
|
|
|
def test_product_only_is_not_probe(self):
|
|
self.assertFalse(nm.is_probe({"ip": "10.0.20.103", "product": "Office 2021"}))
|
|
|
|
def test_full_activation_is_not_probe(self):
|
|
state = {
|
|
"ip": "10.0.20.103",
|
|
"app": "Windows",
|
|
"product": "Windows 11 Pro",
|
|
"host": "DESKTOP-X",
|
|
"status": "Notification",
|
|
}
|
|
self.assertFalse(nm.is_probe(state))
|
|
|
|
|
|
class StateMachineTests(unittest.TestCase):
|
|
"""Drive the regex parser through real-shaped vlmcsd log blocks."""
|
|
|
|
PROBE_BLOCK = [
|
|
"2026-05-10 11:00:00: IPv4 connection accepted: 10.10.107.224:54321.",
|
|
"2026-05-10 11:00:00: IPv4 connection closed: 10.10.107.224:54321.",
|
|
]
|
|
|
|
ACTIVATION_BLOCK = [
|
|
"2026-05-10 11:00:01: IPv4 connection accepted: 10.0.20.103:50001.",
|
|
"2026-05-10 11:00:01: <<< Incoming KMS request",
|
|
"2026-05-10 11:00:01: Application ID : 55c92734-d682-4d71-983e-d6ec3f16059f (Windows)",
|
|
"2026-05-10 11:00:01: Activation ID (Product): 73111121-5638-40f6-bc11-f1d7b0d64300 (Windows 11 Pro)",
|
|
"2026-05-10 11:00:01: Workstation name : DESKTOP-MO2323B",
|
|
"2026-05-10 11:00:01: Licensing status : 2 (Notification)",
|
|
"2026-05-10 11:00:01: IPv4 connection closed: 10.0.20.103:50001.",
|
|
]
|
|
|
|
def _drive(self, lines):
|
|
events = []
|
|
state = {}
|
|
for line in lines:
|
|
state, event = nm.process_line(line, state)
|
|
if event is not None:
|
|
events.append(event)
|
|
return events, state
|
|
|
|
def test_probe_block_emits_probe_event(self):
|
|
events, state = self._drive(self.PROBE_BLOCK)
|
|
self.assertEqual(len(events), 1)
|
|
ev = events[0]
|
|
self.assertEqual(ev.kind, "probe")
|
|
self.assertEqual(ev.ip, "10.10.107.224")
|
|
self.assertEqual(state, {})
|
|
|
|
def test_activation_block_emits_activation_event(self):
|
|
events, state = self._drive(self.ACTIVATION_BLOCK)
|
|
self.assertEqual(len(events), 1)
|
|
ev = events[0]
|
|
self.assertEqual(ev.kind, "activation")
|
|
self.assertEqual(ev.ip, "10.0.20.103")
|
|
self.assertEqual(ev.product, "Windows 11 Pro")
|
|
self.assertEqual(ev.host, "DESKTOP-MO2323B")
|
|
self.assertEqual(ev.status, "Notification")
|
|
self.assertEqual(state, {})
|
|
|
|
def test_interleaved_probe_then_activation(self):
|
|
events, _ = self._drive(self.PROBE_BLOCK + self.ACTIVATION_BLOCK)
|
|
kinds = [e.kind for e in events]
|
|
self.assertEqual(kinds, ["probe", "activation"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|