infra/stacks/ytdlp/main.tf
Viktor Barzin 327ce215b9 [infra] Sweep dns_config ignore_changes across all pod-owning resources [ci skip]
## Context

Wave 3A (commit c9d221d5) added the `# KYVERNO_LIFECYCLE_V1` marker to the
27 pre-existing `ignore_changes = [...dns_config]` sites so they could be
grepped and audited. It did NOT address pod-owning resources that were
simply missing the suppression entirely. Post-Wave-3A sampling (2026-04-18)
found that navidrome, f1-stream, frigate, servarr, monitoring, crowdsec,
and many other stacks showed perpetual `dns_config` drift every plan
because their `kubernetes_deployment` / `kubernetes_stateful_set` /
`kubernetes_cron_job_v1` resources had no `lifecycle {}` block at all.

Root cause (same as Wave 3A): Kyverno's admission webhook stamps
`dns_config { option { name = "ndots"; value = "2" } }` on every pod's
`spec.template.spec.dns_config` to prevent NxDomain search-domain flooding
(see `k8s-ndots-search-domain-nxdomain-flood` skill). Without `ignore_changes`
on every Terraform-managed pod-owner, Terraform repeatedly tries to strip
the injected field.

## This change

Extends the Wave 3A convention by sweeping EVERY `kubernetes_deployment`,
`kubernetes_stateful_set`, `kubernetes_daemon_set`, `kubernetes_cron_job_v1`,
`kubernetes_job_v1` (+ their `_v1` variants) in the repo and ensuring each
carries the right `ignore_changes` path:

- **kubernetes_deployment / stateful_set / daemon_set / job_v1**:
  `spec[0].template[0].spec[0].dns_config`
- **kubernetes_cron_job_v1**:
  `spec[0].job_template[0].spec[0].template[0].spec[0].dns_config`
  (extra `job_template[0]` nesting — the CronJob's PodTemplateSpec is
  one level deeper)

Each injection / extension is tagged `# KYVERNO_LIFECYCLE_V1: Kyverno
admission webhook mutates dns_config with ndots=2` inline so the
suppression is discoverable via `rg 'KYVERNO_LIFECYCLE_V1' stacks/`.

Two insertion paths are handled by a Python pass (`/tmp/add_dns_config_ignore.py`):

1. **No existing `lifecycle {}`**: inject a brand-new block just before the
   resource's closing `}`. 108 new blocks on 93 files.
2. **Existing `lifecycle {}` (usually for `DRIFT_WORKAROUND: CI owns image tag`
   from Wave 4, commit a62b43d1)**: extend its `ignore_changes` list with the
   dns_config path. Handles both inline (`= [x]`) and multiline
   (`= [\n  x,\n]`) forms; ensures the last pre-existing list item carries
   a trailing comma so the extended list is valid HCL. 34 extensions.

The script skips anything already mentioning `dns_config` inside an
`ignore_changes`, so re-running is a no-op.

## Scale

- 142 total lifecycle injections/extensions
- 93 `.tf` files touched
- 108 brand-new `lifecycle {}` blocks + 34 extensions of existing ones
- Every Tier 0 and Tier 1 stack with a pod-owning resource is covered
- Together with Wave 3A's 27 pre-existing markers → **169 greppable
  `KYVERNO_LIFECYCLE_V1` dns_config sites across the repo**

## What is NOT in this change

- `stacks/trading-bot/main.tf` — entirely commented-out block (`/* … */`).
  Python script touched the file, reverted manually.
- `_template/main.tf.example` skeleton — kept minimal on purpose; any
  future stack created from it should either inherit the Wave 3A one-line
  form or add its own on first `kubernetes_deployment`.
- `terraform fmt` fixes to pre-existing alignment issues in meshcentral,
  nvidia/modules/nvidia, vault — unrelated to this commit. Left for a
  separate fmt-only pass.
- Non-pod resources (`kubernetes_service`, `kubernetes_secret`,
  `kubernetes_manifest`, etc.) — they don't own pods so they don't get
  Kyverno dns_config mutation.

## Verification

Random sample post-commit:
```
$ cd stacks/navidrome && ../../scripts/tg plan  → No changes.
$ cd stacks/f1-stream && ../../scripts/tg plan  → No changes.
$ cd stacks/frigate && ../../scripts/tg plan    → No changes.

$ rg -c 'KYVERNO_LIFECYCLE_V1' stacks/ --include='*.tf' --include='*.tf.example' \
    | awk -F: '{s+=$2} END {print s}'
169
```

## Reproduce locally
1. `git pull`
2. `rg 'KYVERNO_LIFECYCLE_V1' stacks/ | wc -l` → 169+
3. `cd stacks/navidrome && ../../scripts/tg plan` → expect 0 drift on
   the deployment's dns_config field.

Refs: code-seq (Wave 3B dns_config class closed; kubernetes_manifest
annotation class handled separately in 8d94688d for tls_secret)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-18 21:19:48 +00:00

367 lines
8.8 KiB
HCL

variable "tls_secret_name" {
type = string
sensitive = true
}
variable "slack_channel" { type = string }
variable "nfs_server" { type = string }
resource "kubernetes_manifest" "external_secret" {
manifest = {
apiVersion = "external-secrets.io/v1beta1"
kind = "ExternalSecret"
metadata = {
name = "ytdlp-secrets"
namespace = "ytdlp"
}
spec = {
refreshInterval = "15m"
secretStoreRef = {
name = "vault-kv"
kind = "ClusterSecretStore"
}
target = {
name = "ytdlp-secrets"
}
dataFrom = [{
extract = {
key = "ytdlp"
}
}]
}
}
depends_on = [kubernetes_namespace.ytdlp]
}
variable "redis_host" { type = string }
resource "kubernetes_namespace" "ytdlp" {
metadata {
name = "ytdlp"
labels = {
"istio-injection" : "disabled"
tier = local.tiers.aux
}
}
lifecycle {
# KYVERNO_LIFECYCLE_V1: goldilocks-vpa-auto-mode ClusterPolicy stamps this label on every namespace
ignore_changes = [metadata[0].labels["goldilocks.fairwinds.com/vpa-update-mode"]]
}
}
module "tls_secret" {
source = "../../modules/kubernetes/setup_tls_secret"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
tls_secret_name = var.tls_secret_name
}
module "nfs_data_host" {
source = "../../modules/kubernetes/nfs_volume"
name = "ytdlp-data-host"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
nfs_server = "192.168.1.127"
nfs_path = "/srv/nfs/ytdlp"
}
module "nfs_highlights_data_host" {
source = "../../modules/kubernetes/nfs_volume"
name = "ytdlp-highlights-data-host"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
nfs_server = "192.168.1.127"
nfs_path = "/srv/nfs/ytdlp-highlights"
}
resource "kubernetes_deployment" "ytdlp" {
# resource "kubernetes_daemonset" "technitium" {
metadata {
name = "ytdlp"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
labels = {
app = "ytdlp"
tier = local.tiers.aux
}
annotations = {
"diun.enable" = "true"
}
}
spec {
# strategy {
# type = "Recreate"
# }
# replicas = 1
selector {
match_labels = {
app = "ytdlp"
}
}
template {
metadata {
labels = {
app = "ytdlp"
}
}
spec {
container {
image = "tzahi12345/youtubedl-material:nightly"
name = "ytdlp"
resources {
requests = {
cpu = "25m"
memory = "512Mi"
}
limits = {
memory = "512Mi"
}
}
port {
container_port = 17442
}
volume_mount {
mount_path = "/app/appdata"
name = "data"
}
volume_mount {
mount_path = "/app/audio"
name = "data"
}
volume_mount {
mount_path = "/app/video"
name = "data"
}
volume_mount {
mount_path = "/app/users"
name = "data"
}
volume_mount {
mount_path = "/app/subscriptions"
name = "data"
}
}
volume {
name = "data"
persistent_volume_claim {
claim_name = module.nfs_data_host.claim_name
}
}
# }
}
}
}
lifecycle {
# KYVERNO_LIFECYCLE_V1: Kyverno admission webhook mutates dns_config with ndots=2
ignore_changes = [spec[0].template[0].spec[0].dns_config]
}
}
resource "kubernetes_service" "ytdlp" {
metadata {
name = "ytdlp"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
labels = {
"app" = "ytdlp"
}
}
spec {
selector = {
app = "ytdlp"
}
port {
name = "ytdlp"
port = 80
target_port = 17442
protocol = "TCP"
}
}
}
module "ingress" {
source = "../../modules/kubernetes/ingress_factory"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
name = "ytdlp"
tls_secret_name = var.tls_secret_name
host = "yt"
dns_type = "non-proxied"
extra_annotations = {
"gethomepage.dev/enabled" = "true"
"gethomepage.dev/name" = "yt-dlp"
"gethomepage.dev/description" = "Video downloader"
"gethomepage.dev/icon" = "youtube-dl.png"
"gethomepage.dev/group" = "Media & Entertainment"
"gethomepage.dev/pod-selector" = ""
}
}
# ----------------------
# yt-highlights service
# ----------------------
resource "kubernetes_deployment" "yt_highlights" {
metadata {
name = "yt-highlights"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
labels = {
app = "yt-highlights"
tier = local.tiers.aux
}
annotations = {
"diun.enable" = "true"
"reloader.stakater.com/auto" = "true"
}
}
spec {
replicas = 1
strategy {
type = "Recreate"
}
selector {
match_labels = {
app = "yt-highlights"
}
}
template {
metadata {
labels = {
app = "yt-highlights"
}
}
spec {
node_selector = {
"gpu" : "true"
}
toleration {
key = "nvidia.com/gpu"
value = "true"
effect = "NoSchedule"
}
container {
name = "yt-highlights"
image = "viktorbarzin/yt-highlights:v20-20260127"
image_pull_policy = "Always"
port {
container_port = 8000
}
env {
name = "ASR_MODEL"
value = "large-v3"
}
env {
name = "ASR_DEVICE"
value = "cuda"
}
env {
name = "OPENROUTER_MODEL"
value = "deepseek/deepseek-r1-0528:free"
}
env {
name = "OPENROUTER_API_KEY"
value_from {
secret_key_ref {
name = "ytdlp-secrets"
key = "openrouter_api_key"
}
}
}
env {
name = "DATA_PATH"
value = "/data"
}
env {
name = "SLACK_BOT_TOKEN"
value_from {
secret_key_ref {
name = "ytdlp-secrets"
key = "slack_bot_token"
}
}
}
env {
name = "SLACK_CHANNEL"
value = var.slack_channel
}
env {
name = "REDIS_URL"
value = "redis://${var.redis_host}:6379/0"
}
# Store model cache on NFS to avoid ephemeral storage eviction
env {
name = "HF_HOME"
value = "/data/cache/huggingface"
}
env {
name = "TORCH_HOME"
value = "/data/cache/torch"
}
volume_mount {
name = "data"
mount_path = "/data"
}
resources {
limits = {
"nvidia.com/gpu" = "1"
}
}
liveness_probe {
http_get {
path = "/health"
port = 8000
}
initial_delay_seconds = 180
period_seconds = 60
timeout_seconds = 60
failure_threshold = 10
}
}
volume {
name = "data"
persistent_volume_claim {
claim_name = module.nfs_highlights_data_host.claim_name
}
}
}
}
}
lifecycle {
# KYVERNO_LIFECYCLE_V1: Kyverno admission webhook mutates dns_config with ndots=2
ignore_changes = [spec[0].template[0].spec[0].dns_config]
}
}
resource "kubernetes_service" "yt_highlights" {
metadata {
name = "yt-highlights"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
labels = {
"app" = "yt-highlights"
}
}
spec {
selector = {
app = "yt-highlights"
}
port {
name = "http"
port = 80
target_port = 8000
protocol = "TCP"
}
}
}
module "highlights_ingress" {
source = "../../modules/kubernetes/ingress_factory"
dns_type = "non-proxied"
namespace = kubernetes_namespace.ytdlp.metadata[0].name
name = "yt-highlights"
tls_secret_name = var.tls_secret_name
host = "yt-highlights"
protected = true
extra_annotations = {
"gethomepage.dev/enabled" = "true"
"gethomepage.dev/name" = "YT Highlights"
"gethomepage.dev/description" = "AI video highlights"
"gethomepage.dev/icon" = "youtube.png"
"gethomepage.dev/group" = "Media & Entertainment"
"gethomepage.dev/pod-selector" = ""
}
}