## Context
Phase 1 of the state-drift consolidation audit (plan Wave 3) identified that
the entire repo leans on a repeated `lifecycle { ignore_changes = [...dns_config] }`
snippet to suppress Kyverno's admission-webhook dns_config mutation (the ndots=2
override that prevents NxDomain search-domain flooding). 27 occurrences across
19 stacks. Without this suppression, every pod-owning resource shows perpetual
TF plan drift.
The original plan proposed a shared `modules/kubernetes/kyverno_lifecycle/`
module emitting the ignore-paths list as an output that stacks would consume in
their `ignore_changes` blocks. That approach is architecturally impossible:
Terraform's `ignore_changes` meta-argument accepts only static attribute paths
— it rejects module outputs, locals, variables, and any expression (the HCL
spec evaluates `lifecycle` before the regular expression graph). So a DRY
module cannot exist. The canonical pattern IS the repeated snippet.
What the snippet was missing was a *discoverability tag* so that (a) new
resources can be validated for compliance, (b) the existing 27 sites can be
grep'd in a single command, and (c) future maintainers understand the
convention rather than each reinventing it.
## This change
- Introduces `# KYVERNO_LIFECYCLE_V1` as the canonical marker comment.
Attached inline on every `spec[0].template[0].spec[0].dns_config` line
(or `spec[0].job_template[0].spec[0]...` for CronJobs) across all 27
existing suppression sites.
- Documents the convention with rationale and copy-paste snippets in
`AGENTS.md` → new "Kyverno Drift Suppression" section.
- Expands the existing `.claude/CLAUDE.md` Kyverno ndots note to reference
the marker and explain why the module approach is blocked.
- Updates `_template/main.tf.example` so every new stack starts compliant.
## What is NOT in this change
- The `kubernetes_manifest` Kyverno annotation drift (beads `code-seq`)
— that is Phase B with a sibling `# KYVERNO_MANIFEST_V1` marker.
- Behavioral changes — every `ignore_changes` list is byte-identical
save for the inline comment.
- The fallback module the original plan anticipated — skipped because
Terraform rejects expressions in `ignore_changes`.
- `terraform fmt` cleanup on adjacent unrelated blocks in three files
(claude-agent-service, freedify/factory, hermes-agent). Reverted to
keep this commit scoped to the convention rollout.
## Before / after
Before (cannot distinguish accidental-forgotten from intentional-convention):
```hcl
lifecycle {
ignore_changes = [spec[0].template[0].spec[0].dns_config]
}
```
After (greppable, self-documenting, discoverable by tooling):
```hcl
lifecycle {
ignore_changes = [spec[0].template[0].spec[0].dns_config] # KYVERNO_LIFECYCLE_V1
}
```
## Test Plan
### Automated
```
$ rg -c 'KYVERNO_LIFECYCLE_V1' stacks/ --include='*.tf' --include='*.tf.example' \
| awk -F: '{s+=$2} END {print s}'
27
$ git diff --stat | grep -E '\.(tf|tf\.example|md)$' | wc -l
21
# All code-file diffs are 1 insertion + 1 deletion per marker site,
# except beads-server (3), ebooks (4), immich (3), uptime-kuma (2).
$ git diff --stat stacks/ | tail -1
20 files changed, 45 insertions(+), 28 deletions(-)
```
### Manual Verification
No apply required — HCL comments only. Zero effect on any stack's plan output.
Future audits: `rg 'KYVERNO_LIFECYCLE_V1' stacks/ | wc -l` must grow as new
pod-owning resources are added.
## Reproduce locally
1. `cd infra && git pull`
2. `rg 'KYVERNO_LIFECYCLE_V1' stacks/` → expect 27 hits in 19 files
3. Grep any new `kubernetes_deployment` for the marker; absence = missing
suppression.
Closes: code-28m
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
266 lines
5.8 KiB
HCL
Executable file
266 lines
5.8 KiB
HCL
Executable file
variable "tls_secret_name" {}
|
|
variable "name" {}
|
|
variable "tag" {
|
|
default = "latest"
|
|
}
|
|
variable "tier" { type = string }
|
|
variable "protected" {
|
|
type = bool
|
|
default = false
|
|
}
|
|
variable "listenbrainz_token" {
|
|
type = string
|
|
default = null
|
|
sensitive = true
|
|
}
|
|
variable "genius_token" {
|
|
type = string
|
|
default = null
|
|
sensitive = true
|
|
}
|
|
variable "dab_visitor_id" {
|
|
type = string
|
|
default = null
|
|
}
|
|
variable "dab_session" {
|
|
type = string
|
|
default = null
|
|
}
|
|
variable "gemini_api_key" {
|
|
type = string
|
|
default = null
|
|
sensitive = true
|
|
}
|
|
variable "memory_limit" {
|
|
type = string
|
|
default = "384Mi"
|
|
}
|
|
variable "cpu_request" {
|
|
type = string
|
|
default = "15m"
|
|
}
|
|
variable "memory_request" {
|
|
type = string
|
|
default = "256Mi"
|
|
}
|
|
variable "extra_annotations" {
|
|
type = map(string)
|
|
default = {}
|
|
}
|
|
variable "navidrome_scan_url" {
|
|
type = string
|
|
default = ""
|
|
sensitive = true
|
|
}
|
|
variable "ha_sofia_url" {
|
|
type = string
|
|
default = ""
|
|
}
|
|
variable "ha_sofia_token" {
|
|
type = string
|
|
default = ""
|
|
sensitive = true
|
|
}
|
|
variable "nfs_music_server" {
|
|
type = string
|
|
default = "192.168.1.127"
|
|
}
|
|
variable "nfs_music_path" {
|
|
type = string
|
|
default = "/srv/nfs/freedify-music"
|
|
}
|
|
|
|
|
|
resource "kubernetes_deployment" "freedify" {
|
|
metadata {
|
|
name = "music-${var.name}"
|
|
namespace = "freedify"
|
|
labels = {
|
|
app = "music-${var.name}"
|
|
tier = var.tier
|
|
}
|
|
}
|
|
spec {
|
|
replicas = 1
|
|
strategy {
|
|
type = "RollingUpdate"
|
|
}
|
|
selector {
|
|
match_labels = {
|
|
app = "music-${var.name}"
|
|
}
|
|
}
|
|
template {
|
|
metadata {
|
|
annotations = {
|
|
"diun.enable" = "true"
|
|
"diun.include_tags" = "^${var.tag}$"
|
|
}
|
|
labels = {
|
|
app = "music-${var.name}"
|
|
}
|
|
}
|
|
spec {
|
|
image_pull_secrets {
|
|
name = "registry-credentials"
|
|
}
|
|
container {
|
|
image = "registry.viktorbarzin.me/freedify:${var.tag}"
|
|
name = "freedify"
|
|
|
|
port {
|
|
container_port = 8000
|
|
}
|
|
env {
|
|
name = "LISTENBRAINZ_TOKEN"
|
|
value = var.listenbrainz_token
|
|
}
|
|
env {
|
|
name = "GENIUS_ACCESS_TOKEN"
|
|
value = var.genius_token
|
|
}
|
|
env {
|
|
name = "DAB_SESSION"
|
|
value = var.dab_session
|
|
}
|
|
env {
|
|
name = "DAB_VISITOR_ID"
|
|
value = var.dab_visitor_id
|
|
}
|
|
env {
|
|
name = "GEMINI_API_KEY"
|
|
value = var.gemini_api_key
|
|
}
|
|
env {
|
|
name = "MUSIC_LIBRARY_PATH"
|
|
value = "/music-library"
|
|
}
|
|
env {
|
|
name = "AUTO_SAVE_TO_LIBRARY"
|
|
value = "true"
|
|
}
|
|
env {
|
|
name = "NAVIDROME_SCAN_URL"
|
|
value = var.navidrome_scan_url
|
|
}
|
|
env {
|
|
name = "HA_SOFIA_URL"
|
|
value = var.ha_sofia_url
|
|
}
|
|
env {
|
|
name = "HA_SOFIA_TOKEN"
|
|
value = var.ha_sofia_token
|
|
}
|
|
volume_mount {
|
|
name = "music-library"
|
|
mount_path = "/music-library"
|
|
}
|
|
resources {
|
|
limits = {
|
|
memory = var.memory_limit
|
|
}
|
|
requests = {
|
|
cpu = var.cpu_request
|
|
memory = var.memory_request
|
|
}
|
|
}
|
|
readiness_probe {
|
|
http_get {
|
|
path = "/"
|
|
port = 8000
|
|
}
|
|
initial_delay_seconds = 5
|
|
period_seconds = 10
|
|
}
|
|
liveness_probe {
|
|
http_get {
|
|
path = "/"
|
|
port = 8000
|
|
}
|
|
initial_delay_seconds = 10
|
|
period_seconds = 30
|
|
failure_threshold = 3
|
|
}
|
|
}
|
|
volume {
|
|
name = "music-library"
|
|
nfs {
|
|
server = var.nfs_music_server
|
|
path = var.nfs_music_path
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
lifecycle {
|
|
ignore_changes = [spec[0].template[0].spec[0].dns_config] # KYVERNO_LIFECYCLE_V1
|
|
}
|
|
}
|
|
|
|
resource "kubernetes_service" "freedify" {
|
|
metadata {
|
|
name = "music-${var.name}"
|
|
namespace = "freedify"
|
|
labels = {
|
|
app = "music-${var.name}"
|
|
}
|
|
}
|
|
|
|
spec {
|
|
selector = {
|
|
app = "music-${var.name}"
|
|
}
|
|
port {
|
|
name = "http"
|
|
port = 80
|
|
target_port = 8000
|
|
}
|
|
}
|
|
}
|
|
|
|
module "ingress" {
|
|
source = "../../../modules/kubernetes/ingress_factory"
|
|
namespace = "freedify"
|
|
name = "music-${var.name}"
|
|
tls_secret_name = var.tls_secret_name
|
|
dns_type = "non-proxied"
|
|
protected = var.protected
|
|
extra_annotations = var.extra_annotations
|
|
}
|
|
|
|
# Unauthenticated ingress for /api/stream/ — allows AirPlay receivers to fetch audio directly
|
|
resource "kubernetes_ingress_v1" "stream-noauth" {
|
|
metadata {
|
|
name = "music-${var.name}-stream"
|
|
namespace = "freedify"
|
|
annotations = {
|
|
"traefik.ingress.kubernetes.io/router.middlewares" = "traefik-retry@kubernetescrd,traefik-rate-limit@kubernetescrd"
|
|
"traefik.ingress.kubernetes.io/router.entrypoints" = "websecure"
|
|
"traefik.ingress.kubernetes.io/router.priority" = "100"
|
|
}
|
|
}
|
|
spec {
|
|
ingress_class_name = "traefik"
|
|
tls {
|
|
hosts = ["music-${var.name}.viktorbarzin.me"]
|
|
secret_name = var.tls_secret_name
|
|
}
|
|
rule {
|
|
host = "music-${var.name}.viktorbarzin.me"
|
|
http {
|
|
path {
|
|
path = "/api/stream/"
|
|
path_type = "Prefix"
|
|
backend {
|
|
service {
|
|
name = "music-${var.name}"
|
|
port {
|
|
number = 80
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|