add json field to store any additional blob of data that may be missing; also populate db when dumping listings

This commit is contained in:
Viktor Barzin 2025-06-06 19:57:50 +00:00
parent 8b2025e700
commit b7a2ea75aa
No known key found for this signature in database
GPG key ID: 4056458DBDBF8863
5 changed files with 22 additions and 37 deletions

View file

@ -6,6 +6,7 @@ from sqlalchemy import pool
from alembic import context
from models import Listing # Import all models here
from database import engine
import sqlmodel
from sqlmodel import SQLModel
# this is the Alembic Config object, which provides

View file

@ -1,32 +0,0 @@
"""add more fields to tables
Revision ID: 4e3b4590920f
Revises: f7486e403e2f
Create Date: 2025-06-04 21:45:41.383520
"""
from typing import Sequence, Union
from alembic import op
import sqlalchemy as sa
# revision identifiers, used by Alembic.
revision: str = '4e3b4590920f'
down_revision: Union[str, None] = 'f7486e403e2f'
branch_labels: Union[str, Sequence[str], None] = None
depends_on: Union[str, Sequence[str], None] = None
def upgrade() -> None:
"""Upgrade schema."""
# ### commands auto generated by Alembic - please adjust! ###
op.add_column('buylisting', sa.Column('lease_left', sa.Integer(), nullable=True))
# ### end Alembic commands ###
def downgrade() -> None:
"""Downgrade schema."""
# ### commands auto generated by Alembic - please adjust! ###
op.drop_column('buylisting', 'lease_left')
# ### end Alembic commands ###

View file

@ -1,8 +1,8 @@
"""add more fields to tables
Revision ID: f7486e403e2f
Revision ID: b78e1ed31eed
Revises:
Create Date: 2025-06-04 20:54:13.838969
Create Date: 2025-06-06 19:50:09.773676
"""
@ -14,7 +14,7 @@ import sqlmodel
# revision identifiers, used by Alembic.
revision: str = "f7486e403e2f"
revision: str = "b78e1ed31eed"
down_revision: Union[str, None] = None
branch_labels: Union[str, Sequence[str], None] = None
depends_on: Union[str, Sequence[str], None] = None
@ -38,10 +38,12 @@ def upgrade() -> None:
),
sa.Column("last_seen", sa.DateTime(), nullable=False),
sa.Column("photo_thumbnail", sqlmodel.sql.sqltypes.AutoString(), nullable=True),
sa.Column("additional_info", sa.JSON(), nullable=False),
sa.Column("service_charge", sa.Float(), nullable=True),
sa.Column(
"council_tax_band", sqlmodel.sql.sqltypes.AutoString(), nullable=True
),
sa.Column("lease_left", sa.Integer(), nullable=True),
sa.PrimaryKeyConstraint("id"),
)
op.create_table(
@ -62,10 +64,17 @@ def upgrade() -> None:
),
sa.Column("last_seen", sa.DateTime(), nullable=False),
sa.Column("photo_thumbnail", sqlmodel.sql.sqltypes.AutoString(), nullable=True),
sa.Column("additional_info", sa.JSON(), nullable=False),
sa.Column("available_from", sa.DateTime(), nullable=True),
sa.Column(
"furnish_type",
sa.Enum("FURNISHED", "UNFURNISHED", "PART_FURNISHED", name="furnishtype"),
sa.Enum(
"FURNISHED",
"UNFURNISHED",
"PART_FURNISHED",
"UNKNOWN",
name="furnishtype",
),
nullable=False,
),
sa.PrimaryKeyConstraint("id"),

View file

@ -156,7 +156,11 @@ def dump_listings(
f"{query_parameters}"
)
data_dir_path = pathlib.Path(data_dir)
asyncio.run(dump_listings_module.dump_listings(query_parameters, data_dir_path))
listings = asyncio.run(
dump_listings_module.dump_listings(query_parameters, data_dir_path)
)
repository = ListingRepository(engine=engine)
asyncio.run(repository.upsert_listings(listings))
@cli.command()

View file

@ -31,6 +31,9 @@ class Listing(SQLModel, table=False):
listing_site: ListingSite = Field(nullable=False)
last_seen: datetime = Field(default_factory=datetime.now, nullable=False)
photo_thumbnail: str | None = Field(default=None, nullable=True)
additional_info: Dict[str, Any] = Field(
default_factory=dict, sa_type=JSON, nullable=False
)
class FurnishType(enum.StrEnum):