viktor/fire-planner
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

whatif: live data refresh, inflation-adjusted spending, legend fix
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details

Browse source 
Three follow-ups to the actualbudget integration:

**Always-fresh autofill.** Drop the one-shot `*AutoFilled` boolean
gates; replace with `nwUserEdited` / `spendingUserEdited` flags. Until
the user types into either field, every refetch (mount, window
focus) updates the form value. Once they edit, we leave it alone. A
small ↻ button next to each anchor input flips the edited flag back
off so the user can re-snap to live data on demand. React Query
configured with staleTime=0 + refetchOnMount='always' +
refetchOnWindowFocus=true so the cache never serves stale numbers.
NW provenance shows the snapshot date.

**Inflation-adjusted spending.** Backend now revalues each trailing
month's nominal pence forward to today's £ using monthly compounding
of `inflation_pct` (default 0.03 ≈ UK CPI 2024-26). Headline
`total_gbp` is the real-£ figure — matches the simulator's
real-GBP convention. Response also includes `nominal_total_gbp` and
`inflation_pct` for transparency. New /spending/annual?inflation_pct=
override param. 10/10 actualbudget tests pass.

**FanChart legend.** The bottom-anchored legend was overlapping the
x-axis label. Moved to top: 8 with itemGap=18 + type=scroll for
narrow viewports; bumped grid top→48 / bottom→56 + xAxis nameGap→28
so nothing collides.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Viktor Barzin 2026-05-10 11:27:22 +00:00
parent 3bfa46ad4f
commit e12e8f9290
8 changed files with 263 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/test_api_spending.py
View file

@ -69,18 +69,20 @@ async def test_spending_annual_excludes_investments_by_default(client: AsyncClie
_mock_two_months(rmock)
# The endpoint asks for 12 months by default but we mocked only 2;
# the remaining 10 are silently dropped (list_months only returns 2).
resp = await client.get("/spending/annual?months=2")
resp = await client.get("/spending/annual?months=2&inflation_pct=0")
assert resp.status_code == 200, resp.text
body = resp.json()
# Usual: 3000 + 4000 = 7000 pence = £70
# 0% inflation → real == nominal. Usual: 3000 + 4000 = 7000p = £70
assert Decimal(body["total_gbp"]) == Decimal("70.00")
# Raw includes investments: 7000 + 60000 = 67000 pence = £670
assert Decimal(body["nominal_total_gbp"]) == Decimal("70.00")
# Raw includes investments: 7000 + 60000 = 67000p = £670
assert Decimal(body["raw_total_gbp"]) == Decimal("670.00")
assert body["window_start"] == "2025-01"
assert body["window_end"] == "2025-02"
assert body["excluded_groups"] == ["Investments and Savings", "Budget Reset"]
assert body["by_group_total_gbp"]["Usual Expenses"] == "70.00"
assert body["by_group_total_gbp"]["Investments and Savings"] == "600.00"
assert Decimal(body["inflation_pct"]) == Decimal("0")
async def test_spending_annual_custom_exclude(client: AsyncClient) -> None:
@ -93,7 +95,9 @@ async def test_spending_annual_custom_exclude(client: AsyncClient) -> None:
patch("fire_planner.actualbudget._today", lambda: date(2025, 3, 15)), \
respx.mock(assert_all_called=False) as rmock:
_mock_two_months(rmock)
resp = await client.get("/spending/annual?months=2&exclude=Usual%20Expenses")
resp = await client.get(
"/spending/annual?months=2&exclude=Usual%20Expenses&inflation_pct=0"
)
assert resp.status_code == 200
body = resp.json()
# Excluding "Usual Expenses" leaves only Investments: £600