All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Adds the read+write endpoints the frontend needs to drive a
ProjectionLab-style UX on top of the existing engine.
- /networth, /networth/history — NW total + per-account from
account_snapshot (frontend chart)
- /scenarios CRUD + projection — list/get/create/patch/delete user
scenarios; cartesian read-only
- /scenarios/{id}/life-events — life event CRUD nested under scenario
- /life-events/{id} — patch + delete by id
- /scenarios/{id}/goals,
/goals/{id} — retirement goal CRUD
- /simulate, /compare — sync, no-DB-write what-if endpoints
Auth: Bearer-token dependency on writes + simulate when API_BEARER_TOKEN
is set; reads always open (lock down via Authentik-fronted ingress in
prod). Existing /recompute keeps its bearer auth.
CORS middleware reads FRONTEND_ORIGINS (comma-separated) for the dev
SPA. Lifespan now provisions the SQLAlchemy engine + session_factory
on app.state and disposes them on shutdown.
40 new tests covering happy paths and validation. 172 tests total.
mypy strict + ruff clean (B008 ignore added — Depends() in defaults
is the canonical FastAPI pattern, not a bug).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
68 lines
2.1 KiB
Python
68 lines
2.1 KiB
Python
"""Retirement-goal CRUD nested under a scenario."""
|
|
from __future__ import annotations
|
|
|
|
from fastapi import APIRouter, Depends, HTTPException
|
|
from sqlalchemy import delete, select
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from fire_planner.api.auth import require_bearer
|
|
from fire_planner.api.dependencies import get_session
|
|
from fire_planner.api.schemas import GoalCreate, GoalOut
|
|
from fire_planner.db import RetirementGoal, Scenario
|
|
|
|
router = APIRouter(tags=["goals"])
|
|
|
|
|
|
@router.get(
|
|
"/scenarios/{scenario_id}/goals",
|
|
response_model=list[GoalOut],
|
|
)
|
|
async def list_goals(
|
|
scenario_id: int,
|
|
session: AsyncSession = Depends(get_session),
|
|
) -> list[RetirementGoal]:
|
|
scen = await session.get(Scenario, scenario_id)
|
|
if scen is None:
|
|
raise HTTPException(status_code=404, detail="Scenario not found")
|
|
rows = (await session.execute(
|
|
select(RetirementGoal).where(RetirementGoal.scenario_id == scenario_id).order_by(
|
|
RetirementGoal.id))).scalars().all()
|
|
return list(rows)
|
|
|
|
|
|
@router.post(
|
|
"/scenarios/{scenario_id}/goals",
|
|
response_model=GoalOut,
|
|
status_code=201,
|
|
dependencies=[Depends(require_bearer)],
|
|
)
|
|
async def create_goal(
|
|
scenario_id: int,
|
|
payload: GoalCreate,
|
|
session: AsyncSession = Depends(get_session),
|
|
) -> RetirementGoal:
|
|
scen = await session.get(Scenario, scenario_id)
|
|
if scen is None:
|
|
raise HTTPException(status_code=404, detail="Scenario not found")
|
|
goal = RetirementGoal(scenario_id=scenario_id, **payload.model_dump())
|
|
session.add(goal)
|
|
await session.commit()
|
|
await session.refresh(goal)
|
|
return goal
|
|
|
|
|
|
@router.delete(
|
|
"/goals/{goal_id}",
|
|
status_code=204,
|
|
response_model=None,
|
|
dependencies=[Depends(require_bearer)],
|
|
)
|
|
async def delete_goal(
|
|
goal_id: int,
|
|
session: AsyncSession = Depends(get_session),
|
|
) -> None:
|
|
goal = await session.get(RetirementGoal, goal_id)
|
|
if goal is None:
|
|
raise HTTPException(status_code=404, detail="Goal not found")
|
|
await session.execute(delete(RetirementGoal).where(RetirementGoal.id == goal_id))
|
|
await session.commit()
|