fire-planner/frontend
Viktor Barzin b40defacf0
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
engine+ui: tax drains the portfolio + Wealthfolio-seeded NW default
Two fixes:

(1) Simulator: portfolio drain is now `w + tax(w)`, not just `w`.
    The pre-2026-05-10 engine recorded tax in tax_hist but never
    subtracted it from the portfolio, so changing jurisdiction only
    moved the median_lifetime_tax cell — the fan chart, success
    rate, and ending percentiles were identical for UK vs Cyprus
    vs Malaysia. (The PLAYBOOK_VIKTOR.md memo from 2026-04-26
    explicitly noted this: "Success rate is regime-independent…
    tax doesn't drain the portfolio in this simulator.")

    Mental model now: spending_target is what the user takes home;
    the tax bill is an additional drag on the same pool. Higher-tax
    jurisdictions therefore drain faster and lower the success
    rate, which is the user's intuition. Trinity 4% effectively
    becomes "4% take-home + tax overhead". 188 tests still pass —
    most use Malaysia (0%) or hit the regime-independent code paths.

(2) /what-if and /scenarios/new now pre-fill nw_seed_gbp from
    GET /networth on first mount (when the wealthfolio_sync mirror
    has data), so opening the form starts from the user's real
    portfolio total instead of the £1.5M placeholder. Once the user
    edits the field, subsequent NW refetches don't clobber it
    (nwAutoFilled latch).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-10 00:21:14 +00:00
..
src engine+ui: tax drains the portfolio + Wealthfolio-seeded NW default 2026-05-10 00:21:14 +00:00
.gitignore frontend: scaffold Vite + React 19 + TS + Tailwind v4 + TanStack Query 2026-05-09 21:53:59 +00:00
index.html frontend: scaffold Vite + React 19 + TS + Tailwind v4 + TanStack Query 2026-05-09 21:53:59 +00:00
package-lock.json frontend: scaffold Vite + React 19 + TS + Tailwind v4 + TanStack Query 2026-05-09 21:53:59 +00:00
package.json frontend: scaffold Vite + React 19 + TS + Tailwind v4 + TanStack Query 2026-05-09 21:53:59 +00:00
tsconfig.app.json frontend: scaffold Vite + React 19 + TS + Tailwind v4 + TanStack Query 2026-05-09 21:53:59 +00:00
tsconfig.json frontend: scaffold Vite + React 19 + TS + Tailwind v4 + TanStack Query 2026-05-09 21:53:59 +00:00
tsconfig.node.json frontend: scaffold Vite + React 19 + TS + Tailwind v4 + TanStack Query 2026-05-09 21:53:59 +00:00
vite.config.ts frontend: scaffold Vite + React 19 + TS + Tailwind v4 + TanStack Query 2026-05-09 21:53:59 +00:00